chore: fix and improve FeedbackWidget removal regex#2151
Open
santamasa wants to merge 1 commit intobase:masterfrom
Open
chore: fix and improve FeedbackWidget removal regex#2151santamasa wants to merge 1 commit intobase:masterfrom
FeedbackWidget removal regex#2151santamasa wants to merge 1 commit intobase:masterfrom
Conversation
|
@santamasa is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
I updated the regular expressions used to remove
FeedbackWidgetfrom the code.The previous patterns weren’t handling all edge cases, such as when there are other imports or attributes in the component.
The new regexes are more reliable and correctly remove the widget in various scenarios.
Notes to reviewers
The changes mainly affect how the
FeedbackWidgetis removed from both import statements and JSX components.The new regexes ensure more robust matching and account for possible variations in the code.
How has it been tested?
These changes have been tested locally by running the script on several markdown and MDX files. No errors were encountered, and the widget was removed as expected.
Have you tested the following pages?
BaseWeb
BaseDocs